Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jni and jnigen to 0.12.0 #1311

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Upgrade jni and jnigen to 0.12.0 #1311

merged 4 commits into from
Oct 2, 2024

Conversation

HosseinYousefi
Copy link
Member

@HosseinYousefi HosseinYousefi commented Oct 1, 2024 •
edited
Loading

Importantly makes cronet able to run on Android 15.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/cronet_http/lib/src/cronet_client.dart 💔 Not covered
pkgs/cronet_http/lib/src/jni/jni_bindings.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

License Headers ⚠️ 
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/cronet_http/lib/src/jni/jni_bindings.dart

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart
pkgs/http/example/main.dart
pkgs/http_client_conformance_tests/example/client_test.dart
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart
pkgs/http_client_conformance_tests/lib/src/multipart_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/multipart_server_web.dart
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_web.dart
pkgs/http_client_conformance_tests/lib/src/redirect_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/redirect_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_headers_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_headers_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_methods_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_methods_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_headers_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_headers_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_web.dart
pkgs/http_client_conformance_tests/lib/src/server_errors_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/server_errors_server_web.dart
pkgs/http_profile/lib/http_profile.dart
pkgs/java_http/lib/src/third_party/java/io/BufferedInputStream.dart
pkgs/java_http/lib/src/third_party/java/io/InputStream.dart
pkgs/java_http/lib/src/third_party/java/io/OutputStream.dart
pkgs/java_http/lib/src/third_party/java/io/_package.dart
pkgs/java_http/lib/src/third_party/java/lang/System.dart
pkgs/java_http/lib/src/third_party/java/lang/_package.dart
pkgs/java_http/lib/src/third_party/java/net/HttpURLConnection.dart
pkgs/java_http/lib/src/third_party/java/net/URL.dart
pkgs/java_http/lib/src/third_party/java/net/URLConnection.dart
pkgs/java_http/lib/src/third_party/java/net/_package.dart
pkgs/ok_http/lib/src/jni/bindings.dart
pkgs/web_socket/example/web_socket_example.dart
pkgs/web_socket/lib/testing.dart
pkgs/web_socket_conformance_tests/example/client_test.dart
pkgs/web_socket_conformance_tests/lib/src/close_local_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/close_local_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/echo_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/echo_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/protocol_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/protocol_server_web.dart

This check can be disabled by tagging the PR with skip-license-check.

Package publish validation ✔️
Package Version Status
package:cronet_http 1.3.3-wip WIP (no publish necessary)
package:cupertino_http 1.5.2-wip WIP (no publish necessary)
package:http 1.2.3-wip WIP (no publish necessary)
package:http_profile 0.1.1-wip WIP (no publish necessary)
package:ok_http 0.1.1-wip WIP (no publish necessary)
package:web_socket 0.1.6 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@HosseinYousefi
Copy link
Member Author

@brianquinlan is the CI not working? I fixed the debug and profile builds and ran the example locally and it seems to work. Feel free to merge once you're comfortable with the status (and eventually publish).

@HosseinYousefi
Copy link
Member Author

I'll merge it but keep the publishing to you

@HosseinYousefi HosseinYousefi merged commit f59cd79 into master Oct 2, 2024
33 of 38 checks passed
@HosseinYousefi HosseinYousefi deleted the upgrade-jni branch October 2, 2024 12:38
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 2, 2024
@devoncarew
[deps] rev bazel_worker, benchmark_harness, boolean_selector, browser…
e679721 
…_launcher, cli_util, clock, csslib, ecosystem, fixnum, glob, html, http, http_multi_server, lints, logging, markdown, matcher, package_config, pub_semver, shelf, source_maps, source_span, stack_trace, stream_channel, string_scanner, term_glyph, test_descriptor, test_process, test_reflective_loader, tools, watcher, web, webkit_inspection_protocol, yaml

Revisions updated by `dart tools/rev_sdk_deps.dart`.

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/02f190b..aa3cc9e):
  aa3cc9e  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/bazel_worker#95)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a06785c..44f125a):
  44f125a  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/benchmark_harness#110)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/c5468f4..d6c7c36):
  d6c7c36  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/boolean_selector#64)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/0acd188..e5fc5d4):
  e5fc5d4  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/browser_launcher#65)

cli_util (https://github.com/dart-lang/cli_util/compare/6a0bb92..c36b394):
  c36b394  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/cli_util#107)

clock (https://github.com/dart-lang/clock/compare/6e43768..7956d60):
  7956d60  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/clock#69)

csslib (https://github.com/dart-lang/csslib/compare/d486627..a3700b0):
  a3700b0  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/csslib#207)

ecosystem (https://github.com/dart-lang/ecosystem/compare/4ba6f15..2d58550):
  2d58550  2024-10-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/ecosystem#302)
  c9d0414  2024-09-30  Devon Carew  update the trebuchet remaining steps output into a markdown list (dart-lang/ecosystem#300)
  492a5bd  2024-09-27  Devon Carew  rev dep on package:lints to 5.0.0 (dart-lang/ecosystem#301)
  0ea4f59  2024-09-26  Devon Carew  Update the output for the trebuchet tool (dart-lang/ecosystem#299)
  70521d7  2024-09-23  Moritz  Update health.dart (dart-lang/ecosystem#298)

fixnum (https://github.com/dart-lang/fixnum/compare/6c19e60..83293b8):
  83293b8  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/fixnum#133)

glob (https://github.com/dart-lang/glob/compare/8b05be8..00a9c82):
  00a9c82  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/glob#97)

html (https://github.com/dart-lang/html/compare/5516387..6d3bc86):
  6d3bc86  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/html#257)

http (https://github.com/dart-lang/http/compare/dfeecf0..f59cd79):
  f59cd79  2024-10-02  Hossein Yousefi  [cronet_http] Upgrade jni and jnigen to 0.12.0 (dart-lang/http#1311)
  aded576  2024-09-25  Bob Nystrom  Migrate to the dart_style DartFormatter API. (dart-lang/http#1307)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/8348be1..e7515b5):
  e7515b5  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/http_multi_server#72)

lints (https://github.com/dart-lang/lints/compare/a97011b..5016d63):
  5016d63  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 (dart-lang/lints#212)

logging (https://github.com/dart-lang/logging/compare/8752902..05116e7):
  05116e7  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/logging#172)

markdown (https://github.com/dart-lang/markdown/compare/f6eaea3..d53feae):
  d53feae  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/markdown#622)

matcher (https://github.com/dart-lang/matcher/compare/d6d573d..31f1358):
  31f1358  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-archive/matcher#255)

package_config (https://github.com/dart-lang/package_config/compare/76934c2..bafff8e):
  bafff8e  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/package_config#159)

pub_semver (https://github.com/dart-lang/pub_semver/compare/d9e5ee6..8cce9d0):
  8cce9d0  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/pub_semver#107)

shelf (https://github.com/dart-lang/shelf/compare/d53a8f9..f560053):
  f560053  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/shelf#448)

source_maps (https://github.com/dart-lang/source_maps/compare/5f82c61..17695e8):
  17695e8  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/source_maps#96)

source_span (https://github.com/dart-lang/source_span/compare/f81cd4a..ec100b7):
  ec100b7  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/source_span#117)

stack_trace (https://github.com/dart-lang/stack_trace/compare/9476c0a..115bcd9):
  115bcd9  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/stack_trace#163)

stream_channel (https://github.com/dart-lang/stream_channel/compare/c0c5a97..f440716):
  f440716  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/stream_channel#111)

string_scanner (https://github.com/dart-lang/string_scanner/compare/a40bbbd..2139417):
  2139417  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/string_scanner#79)

term_glyph (https://github.com/dart-lang/term_glyph/compare/38a158f..19d8c08):
  19d8c08  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/term_glyph#56)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/3b85d38..a3db1ef):
  a3db1ef  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/test_descriptor#71)

test_process (https://github.com/dart-lang/test_process/compare/6223572..52ee3f5):
  52ee3f5  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/test_process#62)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/6e64886..598af2f):
  598af2f  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/test_reflective_loader#65)

tools (https://github.com/dart-lang/tools/compare/3440b74..42996fd):
  42996fde  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/tools#596)

watcher (https://github.com/dart-lang/watcher/compare/0484625..3b85077):
  3b85077  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/watcher#171)

web (https://github.com/dart-lang/web/compare/d16c4bc..8478cd2):
  8478cd2  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/web#312)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/e7418d7..b459c42):
  b459c42  2024-10-01  Devon Carew  Update dependabot.yaml (google/webkit_inspection_protocol.dart#130)
  616e0f2  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (google/webkit_inspection_protocol.dart#129)

yaml (https://github.com/dart-lang/yaml/compare/b3d299e..e773005):
  e773005  2024-10-01  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (dart-lang/yaml#170)

Change-Id: Ic615a1d2c6aa44d2913bae911d06ab5b0605954d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388021
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianquinlan brianquinlan brianquinlan approved these changes

Assignees
No one assigned
Labels
package:cronet_http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HosseinYousefi @brianquinlan